Skip to content

[ICRDMA] Do not scan devices from ctor. Restore ut. EXT-1639 #28087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcherednik merged 1 commit into from
Oct 31, 2025
Merged

[ICRDMA] Do not scan devices from ctor. Restore ut. EXT-1639 #28087

dcherednik merged 1 commit into from
Oct 31, 2025

Conversation

@dcherednik
Copy link
Member

@dcherednik dcherednik commented Oct 31, 2025

Changelog entry

Access to ibverbs library from ctor of LinkManager causes issue with msan for whole project. To solve it we will initialise rdma context only if it needed. Msan tests will not be run for rdma related code.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions
Copy link

github-actions bot commented Oct 31, 2025 •
edited
Loading

🟢 2025-10-31 13:53:55 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025 •
edited
Loading

⚪ 2025-10-31 11:43:51 UTC Pre-commit check linux-x86_64-release-asan for 341f573 has started.
⚪ 2025-10-31 11:44:09 UTC Artifacts will be uploaded here
⚪ 2025-10-31 11:45:30 UTC ya make is running...
🟡 2025-10-31 13:45:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17981 17557 0 155 249 20

🟢 2025-10-31 13:45:48 UTC Build successful.
🟢 2025-10-31 13:46:14 UTC ydbd size 3.8 GiB changed* by +79.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a04e6ba merge: 341f573 diff diff %
ydbd size 4 063 322 088 Bytes 4 063 403 376 Bytes +79.4 KiB +0.002%
ydbd stripped size 1 508 300 152 Bytes 1 508 327 928 Bytes +27.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 31, 2025 •
edited
Loading

⚪ 2025-10-31 11:43:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 341f573 has started.
⚪ 2025-10-31 11:44:15 UTC Artifacts will be uploaded here
⚪ 2025-10-31 11:45:40 UTC ya make is running...
🟡 2025-10-31 13:26:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41701 38859 0 5 2803 34

⚪ 2025-10-31 13:26:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-31 13:37:42 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
80 (only retried tests) 65 0 0 0 15

🟢 2025-10-31 13:37:44 UTC Build successful.
🟢 2025-10-31 13:38:01 UTC ydbd size 2.3 GiB changed* by +35.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a04e6ba merge: 341f573 diff diff %
ydbd size 2 426 565 360 Bytes 2 426 601 568 Bytes +35.4 KiB +0.001%
ydbd stripped size 515 718 280 Bytes 515 718 280 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik merged commit 3aee804 into ydb-platform:main Oct 31, 2025
13 checks passed
@dcherednik dcherednik changed the title [ICRDMA] Do not scan devices from ctor. Restore ut. NBYDB-1639 [ICRDMA] Do not scan devices from ctor. Restore ut. EXT-1639 Oct 31, 2025
dcherednik added a commit to dcherednik/ydb that referenced this pull request Nov 17, 2025
@dcherednik
[ICRDMA] Do not scan devices from ctor. Restore ut. EXT-1639 (ydb-pla…
7cc930d 
…tform#28087)

Access to ibverbs library from ctor of LinkManager causes issue with msan for whole project. To solve it we will initialise rdma context only if it needed. Msan tests will not be run for rdma related code.
dcherednik added a commit that referenced this pull request Nov 19, 2025
@dcherednik
[ICRDMA] Do not scan devices from ctor. Restore ut. EXT-1639 (#28087)
68a5221 
Access to ibverbs library from ctor of LinkManager causes issue with msan for whole project. To solve it we will initialise rdma context only if it needed. Msan tests will not be run for rdma related code.
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
@dcherednik @qyryq
[ICRDMA] Do not scan devices from ctor. Restore ut. EXT-1639 (ydb-pla…
f427bbe 
…tform#28087)

Access to ibverbs library from ctor of LinkManager causes issue with msan for whole project. To solve it we will initialise rdma context only if it needed. Msan tests will not be run for rdma related code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robdrynkin robdrynkin robdrynkin approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcherednik @robdrynkin